The latest updates on your projects. Learn more about Vercel for Git ↗︎

This is really cool! Thanks for putting this PR together.

IMO, the best path to move this ahead would be splitting this PR into two:

1. add the countries field to the Language type
2. all the other filtering changes

The first PR (adding the countries field) could be merged and deployed right away. The filtering part is gonna have to take some more time to review. I think that adding countries to the Language type is such a good improvement that it shouldn't have to wait for the rest of the code to get reviewed before it gets in.

How's this sound to you?

This is really cool! Thanks for putting this PR together.

IMO, the best path to move this ahead would be splitting this PR into two:

1. add the countries field to the Language type
2. all the other filtering changes

The first PR (adding the countries field) could be merged and deployed right away. The filtering part is gonna have to take some more time to review. I think that adding countries to the Language type is such a good improvement that it shouldn't have to wait for the rest of the code to get reviewed before it gets in.

How's this sound to you?

glad you like it. your suggestion sounds good to me; i've never contributed to an open source project before, so is splitting the PR into two something you'll manage, or do you want me to take a crack at it?

No problem! The way I'd do it is to open a new branch based off of main, and copy the countries field resolver code from this PR into there. Then open a new PR based on that branch.

I'll merge that change, and then we can rebase this branch so that it only includes the code related to filtering. At that point, the new countries field will be merged and deployed, and I can spend some time reviewing the remaining changes in here.